Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-5: 5.14.4 -> 5.14.5 #54444

Merged
merged 1 commit into from Jan 27, 2019
Merged

plasma-5: 5.14.4 -> 5.14.5 #54444

merged 1 commit into from Jan 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 21, 2019

https://www.kde.org/announcements/plasma-5.14.5.php

Motivation for this change

Update script mostly, but what I use of it seems good so far?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from ttuegel as a code owner January 21, 2019 22:12
@dtzWill
Copy link
Member Author

dtzWill commented Jan 24, 2019

cc @bkchr (who authored commits for updates to this previously)

I don't use plasma directly but I do include most of it in my system and user environments and things seem good so far :).

@dtzWill
Copy link
Member Author

dtzWill commented Jan 24, 2019

@GrahamcOfBorg test plasma5

@dtzWill
Copy link
Member Author

dtzWill commented Jan 27, 2019

bugfix release, going ahead.

@dtzWill dtzWill merged commit 49dbc7b into NixOS:staging Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg