Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htop: cleanup patchShebangs #54455

Closed
wants to merge 1 commit into from
Closed

htop: cleanup patchShebangs #54455

wants to merge 1 commit into from

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Jan 22, 2019

This was patched out already at hishamhm/htop@1eda099

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
htop: cleanup patchShebangs
779091f 
This was patched out already at hishamhm/htop@1eda099
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2019

@GrahamcOfBorg build htop

@danbst
Copy link
Contributor Author

danbst commented Jan 22, 2019

@Mic92 oh, looks like I should enable sandbox mode right now

@danbst danbst closed this Jan 22, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2019

/bin/sh is ok, /usr/bin/env is not available.

@danbst
Copy link
Contributor Author

danbst commented Jan 22, 2019

Is there any rational on why env isn't allowed in sandbox?

@danbst danbst deleted the htop-cleanup branch January 22, 2019 10:57
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2019

Similar to #1424
Supporting it outside the sandbox is just practical. However letting it slip through
our build can easily introduce impurity. For example a script might use /usr/bin/env python and then it depends on the user's PATH which python it gets. This is why also other linux distributions patch shebangs to point to the absolute interpreter instead of basing it on luck.

@danbst
Copy link
Contributor Author

danbst commented Jan 22, 2019

makes sense now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbvermaa rbvermaa Awaiting requested review from rbvermaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danbst @Mic92 @GrahamcOfBorg