Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luarocks: support more commands: pack/build #54454

Merged
merged 2 commits into from Jan 22, 2019
Merged

luarocks: support more commands: pack/build #54454

merged 2 commits into from Jan 22, 2019

Conversation

teto
Copy link
Member

@teto teto commented Jan 22, 2019 •
edited

Motivation for this change

Extracted from #33903. Endgoal is to improve lua support.
Some luarocks commands wouldn't work (pack/unpack) so I've added the required dependencies.

the 2nd commit is my fork of luarocks that converts luarocks packages into nix packages (providing the lua infrastructure in #33903 gets merged). As such it might represent some dead code so feel free to merge only the first commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

Looks fine. Feel free to add yourself as luarocks maintainer. I am OK with adding luarocks-nix, but I think it is better to have rev and sha256 in an expression under luarocks/ (maybe have luarocks-nix.nix that accepts luarocks argument and overrides it), not in all-packages.nix

@teto
luarocks: support more usage
d7a48fc 
better support for luarocks in a shell (helpful to develop on luarocks).
Also adds unpacker for src.rock/rockspec files.
Also allows to use luarocks to build cmake based rocks.
@teto
luarocks-nix: init
15a8719 
luarocks-nix is a fork of luarocks that adds a "nix" command capable of
converting luarocks package descriptions into nix derivations (though nixpkgs is
still missing the lua infrastructure).
@teto
Copy link
Member Author

teto commented Jan 22, 2019

cool. I've added myself as a maintainer and added a luarocks-nix.nix.

@7c6f434c 7c6f434c merged commit a6a0ba8 into NixOS:master Jan 22, 2019
@teto teto deleted the luarocks_fixes branch January 22, 2019 09:27
@teto teto mentioned this pull request Jan 24, 2019
Closed
21 tasks
@Artturin Artturin mentioned this pull request Jul 14, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @7c6f434c @GrahamcOfBorg