Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_1_1: use the same default CA path as 1.0.* #54438

Merged
merged 1 commit into from Jan 29, 2019
Merged

openssl_1_1: use the same default CA path as 1.0.* #54438

merged 1 commit into from Jan 29, 2019

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jan 21, 2019 •
edited

Fixes #54437

Motivation for this change

I can't see any motivation for the difference.

It actually seems like Robin wanted to try a higher version quickly without dealing with the non-applying patch, and later noone noticed it was dropped. Still, I may be missing something; e.g. it amazes me how long this has gone without being noticed (?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all some binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TODO: perhaps deduplicate the 2x2 patches somehow?

peti
peti approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks for catching this omission!

vcunat added a commit that referenced this pull request Jan 29, 2019
@vcunat
Merge #54438: openssl_1_1: use the same default CA path as 1.0.*
7e6662a
@Profpatsch Profpatsch merged commit 6f61d8b into NixOS:master Jan 29, 2019
@vcunat vcunat deleted the openssl_1_1-ca-path branch January 29, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcunat @peti @Profpatsch @GrahamcOfBorg