Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gscan2pdf: init at 2.3.0 #54434

Merged
merged 1 commit into from Feb 16, 2019
Merged

gscan2pdf: init at 2.3.0 #54434

merged 1 commit into from Feb 16, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jan 21, 2019 •
edited

Motivation for this change

Based on the abandoned github issue #34744.

Tested and validated independently on NixOS 18.09.

This is not the latest version of gscan2pdf.
Version 2.2.2 is out but requires new dependencies such as gtk3 perl modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jan 21, 2019

Used nix-review to checkout this PR. I ran nix build nixpkgs.gscan2pdf and tried out the binary. The GUI works fine, program seems to be working. LGTM.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 21, 2019

Did you encounter any issues with the Gtk3 module?

@jtojnar jtojnar closed this Jan 21, 2019
@jtojnar jtojnar reopened this Jan 21, 2019
@pacien
Copy link
Contributor Author

pacien commented Jan 21, 2019

Did you encounter any issues with the Gtk3 module?

I haven't tried yet.
I will eventually package the newer version at a later time.
Resolving the new dependencies is rather time consuming.

@pacien pacien changed the title gscan2pdf: init at 1.8.11 gscan2pdf: init at 2.2.2 Jan 22, 2019
@pacien
Copy link
Contributor Author

pacien commented Jan 22, 2019

Amended to init gscan2pdf at 2.2.2 instead of 1.8.11.

jtojnar
jtojnar previously requested changes Jan 22, 2019
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/gscan2pdf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/gscan2pdf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/gscan2pdf/default.nix Outdated Show resolved Hide resolved
@pacien pacien force-pushed the gscan2pdf-1 branch 2 times, most recently from ae61efa to 493db7f Compare January 25, 2019 21:45
@pacien pacien mentioned this pull request Jan 25, 2019
Merged
10 tasks
@pacien
gscan2pdf: init at 2.3.0
b73c416 
based on github issue NixOS#34744
closes NixOS#34744
@pacien pacien changed the title gscan2pdf: init at 2.2.2 gscan2pdf: init at 2.3.0 Feb 6, 2019
@pacien
Copy link
Contributor Author

pacien commented Feb 6, 2019

  • This PR has been rebased on master's tip, including imagemagick: add djvu support #54592. All tests are now passing.
  • gscan2pdf has been updated to the freshly released version 2.3.0 instead of 2.2.2. I manually tested the software and it seems to work fine.
  • All requested changes have now been taken into account.

@jtojnar Could you please update your review?

@pacien
Copy link
Contributor Author

pacien commented Feb 16, 2019

Up?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 16, 2019

@GrahamcOfBorg build gscan2pdf

@jtojnar jtojnar merged commit dcb68e3 into NixOS:master Feb 16, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Feb 16, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacien @jtojnar @GrahamcOfBorg