Change: Always build baseset metadata, instead of including it in the repo. #7077
Conversation
PeterN
force-pushed
the
always-build-baseset-metadata
branch
2 times, most recently
from
0b70c54
to
8dca002
Compare
PeterN
force-pushed
the
always-build-baseset-metadata
branch
from
8dca002
to
6f5e5a6
Compare
|
Missed that. Have added it now, but haven't got a version that'll open it. |
|
Hmm, thinking about it, it probably needs to depend on all the language files, not just english.txt. Can't see how to do that, replacing english.txt with *.txt doesn't work at least! |
|
Tried VS2015, works |
I think you'd need, at least for MSBuild, a dummy-output generated from all the language inputs, and then you can depend other things on that dummy-output. |
… repo. This adds a script and project files to generate these files within MSVC.
PeterN
force-pushed
the
always-build-baseset-metadata
branch
from
6f5e5a6
to
635020c
Compare
|
Latest push adds code to build a list of language files and include it in the dependences. Seems to work for me with MSVC 2017. |
|
Seems to work with MSVC 2015 and MSYS2 |
|
I guess the final question now is... is this change a good thing to do? Seeing as eints likely doesn't have the build environment to update these files, this seems the best way to me. |
|
Yeah, IMO this is good. It's less prebuilt files to host in the repository. If it can reasonably be generated during build it should. |
Baseset metadata files are usually out of date as they are not updated when translations are changed.
This also adds a script and project files to generate these files within MSVC.