Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: 1.9.5 -> 1.9.7 #54442

Merged
merged 1 commit into from Jan 27, 2019
Merged

go: 1.9.5 -> 1.9.7 #54442

merged 1 commit into from Jan 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 21, 2019

https://golang.org/doc/devel/release.html#go1.9.minor

Motivation for this change

Unfortunately this fails to build for me
as does our current 1.9.5 :(.

Investigating.

Err by build I think it aborts during testing, not sure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

ofborg seems to not have had any problems

@dtzWill
Copy link
Member Author

dtzWill commented Jan 27, 2019

Indeed, I think my builder was having unrelated issues.

@dtzWill dtzWill merged commit 096ef4f into NixOS:staging Jan 27, 2019
@dtzWill dtzWill deleted the update/go-1.9.7 branch January 27, 2019 19:29
@vcunat
Copy link
Member

vcunat commented Jan 27, 2019 •
edited

Hmm: a687ef9
EDIT: it's inside #54658

@dtzWill
Copy link
Member Author

dtzWill commented Jan 27, 2019

Okay well updating probably doesn't hurt but sounds like not particularly helpful-- and perhaps it should be removed? Marking as insecure effectively removes it from use other than in limited cases users opt-in, right?

I'm happy removing it-- I just had problems with it so my first thought was to see if they were known upstream and since it was old thought I'd try that first :).

@vcunat
Copy link
Member

vcunat commented Jan 27, 2019

Yes, it should throw an error unless you opt-in. I know little about go, so I chose to only mark it (for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkennington wkennington Awaiting requested review from wkennington

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @infinisil @vcunat @GrahamcOfBorg