unison: fix on darwin #54448
Closed
unison: fix on darwin #54448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unison is currently broken by default under Darwin due to a build failure in libglade, which is a transient dependency for unison's gtk2 GUI. Unison technically has a native macOS UI, so it should in principle be possible to package it here and enable it instead of the gtk2 UI by default in darwin, but I struggled to get there. Short of that, a working unison install with a CLI but no GUI is preferable to no unison at all on darwin. The 'UISTYLE=text' option tells the unison makefile to build without any GUI support. This makes the package flag 'enableX11 = false' effectively disable any other unison GUI too, as a simple way of supporting the darwin case above.
|
This is probably ok for now, but ideally we could fix libglade. |
|
#54321 suggests a different fix. Any opinion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unison is currently broken by default under Darwin due to a build
failure in libglade, which is a transient dependency for unison's gtk2
GUI.
Unison technically has a native macOS UI, so it should in principle be
possible to package it here and enable it instead of the gtk2 UI by
default in darwin, but I struggled to get there. Short of that, a
working unison install with a CLI but no GUI is preferable to no unison
at all on darwin.
Things done
The
UISTYLE=textoption tells the unison makefile to build without anyGUI support. This makes the package flag
enableX11 = falseeffectivelydisable any other unison GUI too, as a simple way of supporting the
darwin case above.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)