Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strongswan: ad-hoc fix build #52618

Merged
merged 1 commit into from Dec 21, 2018
Merged

strongswan: ad-hoc fix build #52618

merged 1 commit into from Dec 21, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 21, 2018

Motivation for this change

Simply add libpcap to buildInputs until iptables with pruned libtool files lands
in master.

This should hopefully get us some fresh channel updates for christmas :)

closes #52552

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
strongswan: ad-hoc fix build
ba055b6 
Simply add libpcap to buildInputs until iptables with pruned libtool files lands
in master.
@timokau
Copy link
Member

timokau commented Dec 21, 2018

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Dec 21, 2018

Would adding the hook in question also help?

@hedning
Copy link
Contributor Author

hedning commented Dec 21, 2018

It needs to be added to iptables (which is in staging) unfortunately.

@Mic92 Mic92 merged commit 9234383 into NixOS:master Dec 21, 2018
@hedning
Copy link
Contributor Author

hedning commented Dec 21, 2018

I'll watch out for the next staging-next cycle and push a revert.

@timokau
Copy link
Member

timokau commented Dec 21, 2018

Thanks for making sure the channel can update :)

Another option would be to just push the revert to staging, this way you get it for free once staging lands in master.

@hedning hedning deleted the ad-hoc-fix-strongswan branch December 21, 2018 13:49
@worldofpeace worldofpeace mentioned this pull request Dec 22, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strongswan: doesn't build on master
4 participants
@hedning @timokau @Mic92 @GrahamcOfBorg