Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters [18.09] #52645

Closed
wants to merge 2 commits into from
Closed

Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters [18.09] #52645

wants to merge 2 commits into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Dec 21, 2018 •
edited

Motivation for this change

Fixes #52644

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan tokudan changed the title Firmware fix Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters Dec 21, 2018
@tokudan tokudan changed the title Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters [18.09] Dec 21, 2018
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/6

@badmutex
Copy link
Contributor

badmutex commented Dec 27, 2018 •
edited

I think this would reintroduce #52430.

@Mic92
Copy link
Member

Mic92 commented Dec 27, 2018

Is there a way to only downgrade your firmware, but keep the other updates?

@osmano807
Copy link
Contributor

Is there a way to only downgrade your firmware, but keep the other updates?

For my QCA9377, I just created a new package derivation like this with the latest firmware-5.bin. Hacky, but works.

@tokudan
Copy link
Contributor Author

tokudan commented Jan 4, 2019 •
edited

Is there a way to only downgrade your firmware, but keep the other updates?

I can work around this by keeping a local copy of nixpkgs. But I don't know enough about firmware loading on linux to figure out how to fix this.
Currently a stable version of NixOS broke hardware compatibility, so the responsible commits should be reverted.
If that reintroduces an issue (apparently with amdgpu?) then we need to figure out another solution for that one. From what I've read on #52430 that seems to have been caused by a kernel update, which probably should be reverted, so we can get back to a version that has no software in a completely broken status.

Then we can go about actually fixing the issues as the current state basically means that stable is broken.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/ath10k-driver-crashes-on-startup/2247/2

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-03-feature-freeze/1950/36

@qolii
Copy link
Contributor

qolii commented Apr 27, 2019

Hm, what is to be done for this issue? I see that linux-firmware-nonfree has been updated several times since this was filed, and is now at 2019-04-16. Does that mean this is fixed?

@samueldr
Copy link
Member

(triage) as 18.09 is not supported (since a small while), I'm closing this PR.

Though, I didn't look to see if there was a better resolution on the now current stable, or unstable. This issue sure was problematic, and this is the main reason this wasn't merged: introduce a regression for some users, or fix a regression for some :/.

If there is anything to do on current stable or unstable, feel free to open a new PR, though I don't know if there is anything to do.

Thanks again for contributing, though, sorry for not having a resolution for this during the lifetime of 18.09.

@samueldr samueldr closed this Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tokudan @nixos-discourse @badmutex @Mic92 @osmano807 @qolii @samueldr @GrahamcOfBorg