Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clash-prelude: Disable test #52626

Closed
wants to merge 1 commit into from
Closed

clash-prelude: Disable test #52626

wants to merge 1 commit into from

Conversation

basile-henry
Copy link
Contributor

Motivation for this change

The clash-prelude doctest tests fail due to a missing import

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basile-henry
clash-prelude: Disable test
081e9c2 
The doctest tests fail due to a missing import
@basile-henry
Copy link
Contributor Author

The issue in the doctest test is now resolved here: clash-lang/clash-compiler@9f5f930

But this fix is probably still needed until there is a new hackage release of clash-prelude.

Can we backport this fix to nixpkgs 18.09? I don't know what is the process for this is.

@matthewbauer
Copy link
Member

Is this still needed? We can backport it directly if it's been fixed on master.

peti
peti requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please report this problem to upstream? And, if possible, can you please add a reference to that bug report into the file, using a comment before the override?

@peti peti closed this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@basile-henry @matthewbauer @peti @GrahamcOfBorg @Janik-Haag