Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django_1_11: 1.11.16 -> 1.11.17 #52636

Merged
merged 1 commit into from Dec 22, 2018
Merged

pythonPackages.django_1_11: 1.11.16 -> 1.11.17 #52636

merged 1 commit into from Dec 22, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 21, 2018

Motivation for this change

Django 1.11.17 add support for python3.7 https://docs.djangoproject.com/en/2.1/releases/1.11.17/

I think this needs to be backported to 18.09

Closes #52633

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 21, 2018 17:21
dotlambda
dotlambda reviewed Dec 22, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding meta.license while you're at it?

@marsam
Copy link
Contributor Author

marsam commented Dec 22, 2018

Sure! updated

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2Packages.django_1_11 python3Packages.django_1_11

@dotlambda dotlambda merged commit ddd91fc into NixOS:master Dec 22, 2018
@marsam marsam deleted the fix-django branch December 22, 2018 14:47
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Jan 30, 2019
@marsam
pythonPackages.django_1_11: 1.11.16 -> 1.11.17 (NixOS#52636)
8f9bbbe 
(cherry picked from commit ddd91fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @dotlambda @GrahamcOfBorg