Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: init easywatch and staticjinja #52637

Merged
merged 2 commits into from Jan 5, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Dec 21, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested with both python 2 and 3

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more preferred attribute in the commit msgs would be
pythonPackages.blah: init at blah
Because ofborg will build the packages.

If you look at the https://github.com/NixOS/nixpkgs/pull/52637/checks it built python.

@fgaz
Copy link
Member Author

fgaz commented Jan 5, 2019

All done. Let's see if borg builds it this time

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds fine. Tested the example in the repo successfully.

@worldofpeace worldofpeace merged commit e7551ac into NixOS:master Jan 5, 2019
@worldofpeace
Copy link
Contributor

Thanks @fgaz ❇️

@fgaz fgaz deleted the staticjinja/init branch May 11, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants