Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipreqs: init at 0.4.9 | pythonPackage.yarg: init at 0.1.9 #52647

Merged
merged 3 commits into from Jan 14, 2019

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (ubuntu 18.04)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (pipreqs)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the first commit message to maintainers: update psyanticy's github

pkgs/tools/misc/pipreqs/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/yarg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/yarg/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pipreqs/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pipreqs/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pipreqs/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pipreqs/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/yarg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/yarg/default.nix Outdated Show resolved Hide resolved
@PsyanticY PsyanticY force-pushed the pipreqs-2 branch 2 times, most recently from 1ffddd0 to 5a26ade Compare December 27, 2018 19:41
src = fetchFromGitHub {
owner = "kura";
repo = pname;
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
rev = version;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be changed.

pkgs/tools/misc/pipreqs/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/yarg/default.nix Outdated Show resolved Hide resolved
@PsyanticY
Copy link
Contributor Author

@dotlambda Added the comment as requested, Would you please have a look. ^^

@@ -0,0 +1,25 @@
{ lib, pythonPackages }:

# Using python 2 as when packaging with python 3 pipreqs fails to parse python 2 code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PsyanticY
Copy link
Contributor Author

@dotlambda Updated the last ones as well.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.yarg python3.pkgs.yarg pipreqs

@dotlambda dotlambda merged commit 77c6ca2 into NixOS:master Jan 14, 2019
@PsyanticY PsyanticY deleted the pipreqs-2 branch January 14, 2019 23:11
@PsyanticY
Copy link
Contributor Author

@dotlambda Why GrahamcOfBorg build logs are not shown like usual (just noticed this on couple of recent PR).

@dotlambda
Copy link
Member

This was changed recently: https://discourse.nixos.org/t/ofborg-now-uses-checks/1558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants