New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipreqs: init at 0.4.9 | pythonPackage.yarg: init at 0.1.9 #52647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the first commit message to maintainers: update psyanticy's github
1ffddd0
to
5a26ade
Compare
src = fetchFromGitHub { | ||
owner = "kura"; | ||
repo = pname; | ||
rev = "${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = "${version}"; | |
rev = version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be changed.
@dotlambda Added the comment as requested, Would you please have a look. ^^ |
pkgs/tools/misc/pipreqs/default.nix
Outdated
@@ -0,0 +1,25 @@ | |||
{ lib, pythonPackages }: | |||
|
|||
# Using python 2 as when packaging with python 3 pipreqs fails to parse python 2 code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@dotlambda Updated the last ones as well. |
@GrahamcOfBorg build python2.pkgs.yarg python3.pkgs.yarg pipreqs |
@dotlambda Why GrahamcOfBorg build logs are not shown like usual (just noticed this on couple of recent PR). |
This was changed recently: https://discourse.nixos.org/t/ofborg-now-uses-checks/1558 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
) (pipreqs)nix path-info -S
before and after)