Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icu: 59.1 -> 63.1 #52632

Closed
wants to merge 1 commit into from
Closed

icu: 59.1 -> 63.1 #52632

wants to merge 1 commit into from

Conversation

alyssais
Copy link
Member

Motivation for this change

This cherry-picks #52416 to staging, and then updates the icu package to point to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member Author

Whoops, bad rebase.

@JohnAZoidberg JohnAZoidberg mentioned this pull request Apr 26, 2019
Merged
10 tasks
@mmahut
Copy link
Member

mmahut commented May 22, 2019

64.2 is out

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/29

@teto
Copy link
Member

teto commented Jul 12, 2019

closed by #60250

@teto teto closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alyssais @mmahut @nixos-discourse @teto @GrahamcOfBorg