Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivan: 054 -> 055 #52642

Merged
merged 1 commit into from Dec 22, 2018
Merged

ivan: 054 -> 055 #52642

merged 1 commit into from Dec 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 21, 2018

Motivation for this change

IVAN update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 21, 2018

@GrahamcOfBorg build ivan

Mic92
Mic92 reviewed Dec 21, 2018
View reviewed changes
pkgs/games/ivan/default.nix
# Enable wizard mode
cmakeFlags = ["-DCMAKE_CXX_FLAGS=-DWIZARD" "-DFORCE_HOME_AS_STATE_DIR=ON"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off by default https://github.com/Attnam/ivan/blob/master/CMakeLists.txt#L16

Copy link
Author

@ghost ghost Dec 21, 2018 •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually created this option, but now it's useless.
Because after some discussions (#488, #493) it was decided to store all the data (including save, bone, highscore, config and temporary files) in the current user's .ivan directory.
So I created new PR, but IVAN devs created their own.
So the option still exists now, but it doesn't affect anything. Everything is already stored in the current user's .ivan directory by default.

@Mic92 Mic92 merged commit c485a49 into NixOS:master Dec 22, 2018
@ghost
Copy link
Author

ghost commented Dec 24, 2018

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg