Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nose-randomly: add checkPhase #52628

Merged
merged 1 commit into from Dec 23, 2018
Merged

pythonPackages.nose-randomly: add checkPhase #52628

merged 1 commit into from Dec 23, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 21, 2018

Motivation for this change

Otherwise timeouts in darwin python2 with the default checkPhase https://hydra.nixos.org/build/86142595

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 21, 2018 14:31
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.nose-randomly python3.pkgs.nose-randomly

@dotlambda dotlambda merged commit ff004d0 into NixOS:master Dec 23, 2018
@marsam marsam deleted the fix-nose-randomly-darwin branch December 23, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @dotlambda @GrahamcOfBorg