Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: fix pdfjs #52623

Merged
merged 1 commit into from Dec 22, 2018
Merged

qutebrowser: fix pdfjs #52623

merged 1 commit into from Dec 22, 2018

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Dec 21, 2018 •
edited

Pdfjs was downloaded in two derivations, where one is sufficient.

Also there was allegedly a typo in the download URL (the v in front of the version).

Motivation for this change

This addresses #52615, but only fixes it on master. I still think, that it could be backported to nixos-18.09, as it doesn't make the situation worse and fixes the download URL.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
qutebrowser: fix pdfjs
0be7bfe 
Pdfjs was downloaded in two derivations, where one is sufficient.

Also there was allegedly a typo in the download URL.
@erictapen erictapen mentioned this pull request Dec 21, 2018
Closed
@erictapen erictapen changed the title [WIP] qutebrowser: fix pdfjs qutebrowser: fix pdfjs Dec 22, 2018
@erictapen
Copy link
Member Author

@GrahamcOfBorg build qutebrowser

@veprbl veprbl merged commit 0d7546c into NixOS:master Dec 22, 2018
@veprbl
Copy link
Member

veprbl commented Dec 22, 2018 •
edited

Backported to release-18.09 in 5002174, but, like you said, doesn't solve the problem.

@erictapen erictapen deleted the pdfjs branch December 23, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @veprbl @GrahamcOfBorg