Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: update the bucket policies #71

Merged
merged 1 commit into from Dec 20, 2018
Merged

terraform: update the bucket policies #71

merged 1 commit into from Dec 20, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Dec 20, 2018

Formatted with jq

nix-releases inherits the policy from nix-cache

should fix #70

@zimbatm
terraform: update the bucket policies
1f42bc8 
Formatted with jq

nix-releases inherits the policy from nix-cache
@zimbatm
Copy link
Member Author

zimbatm commented Dec 20, 2018

merging as it has been already applied

@zimbatm zimbatm merged commit eb95ce5 into master Dec 20, 2018
@zimbatm zimbatm deleted the zimbatm/bucket-policies branch December 20, 2018 10:10
@edolstra
Copy link
Member

Shouldn't the bucket policies be removed from nixos-org/network.nix? Now they're managed in two places.

zimbatm added a commit that referenced this pull request Dec 20, 2018
@zimbatm
fixup! terraform: update the bucket policies (#71)
08cf8cf
@zimbatm
Copy link
Member Author

zimbatm commented Dec 20, 2018

yes good point. #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channel updates are broken by AWS + Terraform changes
2 participants
@zimbatm @edolstra