Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift: migrate to using buildGoPackage #52572

Merged
merged 1 commit into from Jan 11, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 20, 2018

Motivation for this change

Part of #52469, make the runc derivation using buildGoPackage 👼

This means openshift becomes a multi-output derivation :
openshift.bin and openshift. (I'm not entirely sure on that one 😅 )

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This means `openshift` becomes a multi-output derivation :
`openshift.bin` and `openshift`

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the 52469-openshift-to-buildgopackage branch from 2cb8bae to e4bc05f Compare December 20, 2018 17:46
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

@GrahamcOfBorg build openshift

@Mic92 Mic92 merged commit 566cc6b into NixOS:master Jan 11, 2019
@vdemeester vdemeester deleted the 52469-openshift-to-buildgopackage branch January 11, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants