Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: fix build on x86_64-darwin #52566

Merged
merged 1 commit into from Dec 20, 2018
Merged

openblas: fix build on x86_64-darwin #52566

merged 1 commit into from Dec 20, 2018

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Dec 20, 2018 •
edited

Motivation for this change

@FRidh after upgrading openblas from 0.3.3 to 0.3.4 in 4deb04a the x86_64-darwin job started failing.

This PR fixes that.

See: OpenMathLib/OpenBLAS#1926

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build openblas

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Dec 20, 2018
@basvandijk basvandijk mentioned this pull request Dec 20, 2018
Closed
@basvandijk
Copy link
Member Author

Both x86_64-linux and x86_64-darwin build for me.

@Mic92 Mic92 merged commit e166aca into NixOS:master Dec 20, 2018
@LnL7
Copy link
Member

LnL7 commented Dec 20, 2018

What's the rebuild count if we make the patch darwin only? Given that this only rebuilds existing failures and the hydra queue is relatively small at the moment I'd prefer to put this in master to fix the regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basvandijk @LnL7 @Mic92 @GrahamcOfBorg