Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-secret: Add gawk to wrapper #52562

Merged
merged 1 commit into from Dec 20, 2018
Merged

Conversation

acairncross
Copy link
Contributor

Motivation for this change

The git-secret script(s) use gawk. Before this change:

$ nix-env -f ~/code/nixpkgs -iA git-secret # master branch of nixpkgs
installing 'git-secret-0.2.4'
$ git secret init
/nix/store/i5xpjcrjvsh89ckkw470c94561nzw948-git-secret-0.2.4/bin/.git-secret-wrapped: line 129: gawk: command not found
'/home/aiken/code/git-secret-test/.gitsecret/' created.
/nix/store/i5xpjcrjvsh89ckkw470c94561nzw948-git-secret-0.2.4/bin/.git-secret-wrapped: line 254: gawk: command not found

@lo1tuma

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The `git-secret` script(s) use `gawk`.
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

Is a backport required?

@acairncross acairncross deleted the git-secret-gawk branch December 20, 2018 11:03
@acairncross
Copy link
Contributor Author

The issue does also exist in 18.09, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants