Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x265: fix build on ARM #52549

Closed
wants to merge 1 commit into from
Closed

x265: fix build on ARM #52549

wants to merge 1 commit into from

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

x265 does not build on ARM. There is a proposed patch upstream that fixes this: https://bitbucket.org/multicoreware/x265/issues/406/arm-assembly-fail-to-compile-on-18

Things done

I applied this patch in nixpkgs. x265 builds on armv7l-linux now.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

@GrahamcOfBorg build x265

@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

The committer in the pull request is unsure about the alignment. Have you checked wether the built version still produces correct results?

@timokau
Copy link
Member

timokau commented Dec 20, 2018

This causes 501+ linux rebuilds and should probably go through staging.

@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

I can cherry-pick it there also.

@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

applied in 07a6bc6

@Mic92 Mic92 closed this Dec 20, 2018
@lopsided98 lopsided98 deleted the x265-arm-fix branch December 21, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @Mic92 @timokau @GrahamcOfBorg