Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shairport-sync: don't daemonize #52554

Merged
merged 1 commit into from Dec 20, 2018
Merged

shairport-sync: don't daemonize #52554

merged 1 commit into from Dec 20, 2018

Conversation

nornagon
Copy link
Contributor

Motivation for this change

As is, the shairport-sync service immediately exits after boot with the following message:

Dec 19 22:26:25 nixos shairport-sync[11226]: shutdown requested...

It looks like this is emitted when shairport-sync receives SIGINT or SIGTERM. My guess is that this is coming from systemd, though I don't understand much about the details.

The upstream systemd unit doesn't pass -d.

Removing -d from the arguments list by overriding it in my local configuration fixes the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nornagon
shairport-sync: don't daemonize
654c312 
This flag causes the shairport-sync server to attempt to daemonize, but it looks like systemd is already handling that. With the `-d` argument, shairport-sync immediately exits—it seems that something (systemd I'm guessing?) is sending it SIGINT or SIGTERM.

The [upstream systemd unit](https://github.com/mikebrady/shairport-sync/blob/master/scripts/shairport-sync.service.in#L10) doesn't pass `-d`.
@Mic92 Mic92 merged commit 96952fe into NixOS:master Dec 20, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 20, 2018

Is a backport required?

@nornagon
Copy link
Contributor Author

It's broken in 18.09, but I don't know what the backport policy is here :) It's fixable in configuration.nix by overriding args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @Mic92 @GrahamcOfBorg