containerd: migrate to using buildGoPackage #52563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 20, 2018
| manName="$(basename "$manFile")" # "docker-build.1" | ||
| number="$(echo $manName | rev | cut -d'.' -f1 | rev)" | ||
| mkdir -p "$manRoot/man$number" | ||
| gzip -c "$manFile" > "$manRoot/man$number/$manName.gz" |
There was a problem hiding this comment.
I think we automatically compress manpages.
There was a problem hiding this comment.
oh 🤔 then there is some other packages that should change too
|
oh this broke the docker derivation 😅 I'll fix 👼 |
vdemeester
force-pushed
the
52469-containerd-to-buildgopackage
branch
from
7e369b6
to
05e33dd
Compare
… and add man pages, which means `containerd` becomes a multi-output derivation : `containerd.bin` and `containerd.man`. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
52469-containerd-to-buildgopackage
branch
from
05e33dd
to
17ddccc
Compare
|
@GrahamcOfBorg test docker |
|
@GrahamcOfBorg build nixosTests.docker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Part of #52469, make the
runcderivation usingbuildGoPackage👼… and add man pages, which means
containerdbecomes a multi-outputderivation :
containerd.binandcontainerd.man.cc @Mic92
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)