Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcompris: 0.91 -> 0.95 #52567

Merged
merged 2 commits into from Dec 20, 2018
Merged

gcompris: 0.91 -> 0.95 #52567

merged 2 commits into from Dec 20, 2018

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Dec 20, 2018

Motivation for this change

Bump version to 0.95.

Previous version (0.91) was not properly working with qt > 5.9, it seems fixed now, so I removed the custom pinning to qt 5.9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@guibou guibou mentioned this pull request Dec 20, 2018
Closed
8 tasks
@peterhoeg
Copy link
Member

peterhoeg commented Dec 20, 2018 •
edited

Do you want to bump qmlbox2d as well?

@guibou
Copy link
Contributor Author

guibou commented Dec 20, 2018

@peterhoeg Well, there is nothing really new in qmlbox2d since last commit, however I'll bump it and setup it for qt > 5.9.

Actually I'm surprised that it even works, gcompris with qt 5.11 and qmlbox2d with qt 5.9.

@guibou
Copy link
Contributor Author

guibou commented Dec 20, 2018

@peterhoeg done.

@Ma27
Copy link
Member

Ma27 commented Dec 20, 2018

When I build and start gcompris, I get a screen with the following message:

Error for gcompris

@guibou
Copy link
Contributor Author

guibou commented Dec 20, 2018

@Ma27 Have you nix-env -i ./result to install gcompris into your env? For some reasons, qt packages must be installed in an environment to work.

@Mic92 Mic92 merged commit 1bb5662 into NixOS:master Dec 20, 2018
@Ma27
Copy link
Member

Ma27 commented Dec 20, 2018

@Mic92 was faster, but I can confirm that it works fine when testing this with nix run :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guibou @peterhoeg @Ma27 @Mic92 @GrahamcOfBorg