Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-wrap: fix for pypy #52568

Merged
merged 2 commits into from Dec 20, 2018
Merged

python-wrap: fix for pypy #52568

merged 2 commits into from Dec 20, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 20, 2018 •
edited

Things done

still building...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner December 20, 2018 14:20
@Mic92 Mic92 mentioned this pull request Dec 20, 2018
Merged
8 tasks
@Mic92
Copy link
Member Author

Mic92 commented Dec 20, 2018

python2:

$ nix run '(with import <nixpkgs> {}; python2.withPackages (ps: [ps.virtualenv]))' -c virtualenv --version
[2 built, 1 copied, 0.0 MiB DL]
16.1.0

python3:

nix run '(with import <nixpkgs> {}; python3.withPackages (ps: [ps.virtualenv]))' -c virtualenv --version
[4 built, 3 copied (62.8 MiB), 10.9 MiB DL]
16.1.0

@Mic92
nixos/glusterfs: remove unused PYTHONPATH
2dd13d4 
this directory does not exists
@Mic92 Mic92 merged commit 8fcabc9 into NixOS:staging Dec 20, 2018
@Mic92
Copy link
Member Author

Mic92 commented Dec 20, 2018

also works for pypy!

@Mic92 Mic92 deleted the pypy-fix branch January 15, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @FRidh @GrahamcOfBorg