Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperledger-fabric: init at 1.3.0 #52551

Merged
merged 1 commit into from Dec 20, 2018
Merged

hyperledger-fabric: init at 1.3.0 #52551

merged 1 commit into from Dec 20, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 19, 2018

Motivation for this change

closes #52542

cc: @rsoeldner

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Looks fine and builds locally, I can see the help menus. Though I won't be any help in testing the function ATM.

@rsoeldner
Copy link

@worldofpeace I'm using this nix derivation already and (at least until now) it works perfectly.

@worldofpeace
Copy link
Contributor

@worldofpeace I'm using this nix derivation already and (at least until now) it works perfectly.

Sounds good, I'll merge this 👍

@worldofpeace worldofpeace merged commit 0410537 into NixOS:master Dec 20, 2018
@marsam marsam deleted the init-hyperledger-fabric branch December 20, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package request: hyperledger-fabric
4 participants
@marsam @worldofpeace @rsoeldner @GrahamcOfBorg