Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv3: fix OpenCV issue 13207 #52556

Closed
wants to merge 2 commits into from
Closed

opencv3: fix OpenCV issue 13207 #52556

wants to merge 2 commits into from

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Dec 20, 2018 •
edited

Motivation for this change

See: opencv/opencv#13232

@nh2 this also fixes the test of haskell-opencv HEAD where we got the following error:

...
    Feature Detection
      houghLinesP:
libgomp: Out of memory allocating 927712937064 bytes
Test suite test-opencv: FAIL
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
opencv3: fix OpenCV issue 13207
2572dd1 
See: opencv/opencv#13232

This also fixes the test of haskell-opencv HEAD where we got the
following error:

    Feature Detection
      houghLinesP:
libgomp: Out of memory allocating 927712937064 bytes
Test suite test-opencv: FAIL
@basvandijk basvandijk self-assigned this Dec 20, 2018
@basvandijk
Copy link
Member Author

I see the same bug exists in opencv4. I'll fix that as well in a separate PR.

@basvandijk
opencv4: fix OpenCV issue 13207
12048d2 
This is the same fix as for opencv3 in commit:
2572dd1
@basvandijk
Copy link
Member Author

Actually I just force-pushed the opencv4 fix in this PR. Will merge when ofborg is happy:

@GrahamcOfBorg build opencv3 opencv4

@basvandijk
Copy link
Member Author

For some reason I couldn't merge this PR. Probably because ofborg is failing on the x86_64-darwin build. This is caused by the openblas dependency which fails to build. I reported this upstream. Since this is not caused by this PR and I tested this myself I just merged this manually in master.

@basvandijk basvandijk closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@basvandijk basvandijk

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @GrahamcOfBorg