-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDI engine for font glyph rendering as a replacement for FreeType #6980
Conversation
9d36a0a
to
0b74559
Compare
In preliminary testing, this seems to work correctly. I haven't tested with non-English languages yet, and it's probably also worth doing some performance measurements. |
I made some measurements with TIC/TOC. It seems that the Working around that is more stupid than expected. Simply pre-allocating a guess for the memory works for most glyphs, except if it is something like space, where you have to pass 0 for the size. And of course the failed function call will not tell you the needed memory size so you end up calling the function thrice. A possible (and ugly) optimization would be https://gist.github.com/michicc/924a562decf38829259e2860a869d2c3 |
0b74559
to
b1b8f79
Compare
We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles! |
b1b8f79
to
91fc02a
Compare
This would be a fix for #7032, even if not intended that way. |
#7032 is now fixed so this is again a bit less serious, I suppose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires conflict resolution
… does not depend on Freetype and into one that does. This makes it easier to add other TrueType font rendering engines.
… including FreeType. Building with FreeType is still possible and will take precedence over the GDI renderer, but the project files don't include FreeType anymore by default. Combining GDI rendering with ICU text layout is untested.
… have one, instead of repeatedly guessing the font.
91fc02a
to
3b1ae12
Compare
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
This is a semi-serious PR that supplies a native Windows GDI font rendering back-end. It drops FreeType as a required lib, OTOH it is one more code path to maintain while FreeType isn't really causing problems.
Building with FreeType is still possible and will take precedence over the GDI renderer, but
the project files don't include FreeType any more by default. Combining GDI rendering with ICU text layout is untested.
As this is partly a programming exercise, I'm not too invested in it to drop.