Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox: 1.29.3 -> 1.30.1 #56010

Merged
merged 1 commit into from Feb 22, 2019
Merged

busybox: 1.29.3 -> 1.30.1 #56010

merged 1 commit into from Feb 22, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 18, 2019 •
edited by vcunat

Motivation for this change

For changes see https://busybox.net
(most of which are part of 1.30.0).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Need to test bootstrap as comment indicates, at least :).

@dtzWill
busybox: 1.29.3 -> 1.30.1
8019d4a 
For changes see https://busybox.net
(most of which are part of 1.30.0).
@vcunat
Copy link
Member

vcunat commented Feb 18, 2019

Fixes a security problem, probably: #54798

@dtzWill
Copy link
Member Author

dtzWill commented Feb 21, 2019

@GrahamcOfBorg eval

@vcunat
Copy link
Member

vcunat commented Feb 22, 2019

I did run the bootstrap test, BTW.

vbgl pushed a commit to vbgl/nixpkgs that referenced this pull request Feb 22, 2019
@vcunat
Merge NixOS#56010: busybox: 1.29.3 -> 1.30.1
65c085e 
There's a CVE fix inside, so let's not wait for long.
@vcunat vcunat merged commit 8019d4a into NixOS:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @vcunat @GrahamcOfBorg