Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandoc: remove bit no longer needed #56008

Merged
merged 1 commit into from Feb 24, 2019
Merged

pandoc: remove bit no longer needed #56008

merged 1 commit into from Feb 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 18, 2019

Motivation for this change

As comment indicates, 2.6 doesn't need this anymore :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Feb 18, 2019

Looks like postInstall can go too, looking at hackage-packages.nix. :)

@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@dtzWill
Copy link
Member Author

dtzWill commented Feb 21, 2019

Look good? :)

@dtzWill
Copy link
Member Author

dtzWill commented Feb 23, 2019

cc #56180 . Feel free to include this as part of that PR :).

@srhb
Copy link
Contributor

srhb commented Feb 24, 2019

Sorry, totally thought I merged this already. Done in aa88d65

@srhb srhb closed this Feb 24, 2019
@srhb srhb merged commit 374115a into NixOS:master Feb 24, 2019
srhb added a commit that referenced this pull request Feb 24, 2019
@srhb
Merge #56008
aa88d65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @srhb @matthewbauer @GrahamcOfBorg