Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/logind: Add defaultText to config option since it's not static value. #56012

Merged
merged 1 commit into from Feb 22, 2019
Merged

nixos/logind: Add defaultText to config option since it's not static value. #56012

merged 1 commit into from Feb 22, 2019

Conversation

matix2267
Copy link
Contributor

Motivation for this change

Sorry for forgetting that in #55920

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxij
Copy link
Member

oxij commented Feb 18, 2019 via email

@matix2267
Copy link
Contributor Author

I have no idea what is the error in those automated checks.

@oxij
Copy link
Member

oxij commented Feb 22, 2019

@GrahamcOfBorg eval

@infinisil infinisil merged commit bcda0e3 into NixOS:master Feb 22, 2019
@matix2267 matix2267 deleted the logind-lid-switch-external-power branch February 23, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matix2267 @oxij @grahamc @infinisil @GrahamcOfBorg