all-packages.nix: move defaults to package files continues^2 #56026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are already inherited in the parent derivation.
7c6f434c
reviewed
Feb 19, 2019
| , cudaSupport ? stdenv.isLinux, cudatoolkit | ||
| , cudnnSupport ? false, cudnn ? null | ||
| , cudaSupport ? config.cudaSupport or false, cudatoolkit | ||
| , cudnnSupport ? cudaSupport, cudnn ? null |
There was a problem hiding this comment.
Do you want to change the default on Linux here? Given it is Deep Learning, running it CPU-only might be too painful to be useful…
7c6f434c
reviewed
Feb 19, 2019
| }: | ||
| , firmware ? config.pcmciaUtils.firmware or [] # Special pcmcia cards. | ||
| , configOpts ? config.pcmciaUtils.config or null # Special hardware (map memory & port & irq) | ||
| }: # used to generate postInstall script. |
There was a problem hiding this comment.
I wonder how to find out how many users will be hit by such an incompatible rename.
|
Do you want to change the default on Linux here? Given it is Deep Learning, running it CPU-only might be too painful to be useful…
The default doesn't actually change, see the related piece in `all-packages.nix`.
I wonder how to find out how many users will be hit by such an incompatible rename.
`config.pcmciaUtils` option name does not change, package derivation option name change does not really matter because if somebody has it set via override they'll just get a evaluation error.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
A continuation of #55129 and #55732. Another noop.
git logA bunch of these.
xmonad_log_applet: move defaults to package file, cleanup
These are already inherited in the parent derivation.
nix-instantiateenvironmentnix-env -qaPdiffs/cc @7c6f434c from #55129 and @bendlas, @volth, @samueldr from #55732