Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: Fix build with LDAP #56058

Merged
merged 1 commit into from Mar 12, 2019
Merged

exim: Fix build with LDAP #56058

merged 1 commit into from Mar 12, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Feb 19, 2019

The lber library is now required, see also:
https://bugs.archlinux.org/task/27509

Motivation for this change

It does not build with LDAP

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
exim: Fix build with LDAP
430b6ce 
The lber library is now required, see also:
https://bugs.archlinux.org/task/27509
@dasJ
Copy link
Member Author

dasJ commented Feb 19, 2019

Ah, log from my Hydra:

<3>gcc -o exim
<3>/nix/store/x1ppmzlkafk8p47bknfa116b34ljwhz5-binutils-2.30/bin/ld: lookups/lookups.a(ldap.o): undefined reference to symbol 'ber_pvt_opt_on'
<3>/nix/store/hdizpwklxl3145bkyyzi7ypv5ig4nqdn-openldap-2.4.46/lib/liblber-2.4.so.2: error adding symbols: DSO missing from command line
<3>collect2: error: ld returned 1 exit status
<3>make[1]: *** [Makefile:629: exim] Error 1
<3>make[1]: Leaving directory '/build/exim-4.91/build-Linux-x86_64'
<3>make: *** [Makefile:35: all] Error 2
<3>builder for '/nix/store/mjmq0n19w66yyzmal1vyqs8vyyckdg88-exim-4.91.drv' failed with exit code 2

@dasJ
Copy link
Member Author

dasJ commented Feb 19, 2019

Can somebody with appropriate permissions build exim?

@srhb
Copy link
Contributor

srhb commented Feb 20, 2019

@GrahamcOfBorg build exim

@veprbl
Copy link
Member

veprbl commented Mar 12, 2019

cc @4z3

@veprbl veprbl merged commit b2a6183 into NixOS:master Mar 12, 2019
@dasJ dasJ deleted the exim-ldap-fix branch March 13, 2019 12:53
This was referenced Mar 13, 2019
Merged
Closed
veprbl pushed a commit that referenced this pull request Mar 13, 2019
@dasJ @veprbl
exim: Fix build with LDAP (#56058)
a9b5d36 
The lber library is now required, see also:
https://bugs.archlinux.org/task/27509

(cherry picked from commit b2a6183)
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @srhb @veprbl @GrahamcOfBorg