zoneminder: Fix locally created database #56015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval |
|
Hey @peterhoeg, Could you have a look at the patches? I am concerned the mysql username impacts the non-locally created use case. |
amazari
requested review from
alyssais,
basvandijk,
edolstra,
Ericson2314,
FRidh,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
Profpatsch,
rycee,
thoughtpolice,
ttuegel and
zimbatm
as code owners
You might want to rebase this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In its current form the database.createLocally flag is broken. Those patches try to fix it.
Things done
After fixing types in a previous one, the two here fix:
Only tested locally after recreating /etc/mysql_init file.
Ping @peterhoeg