Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7189: Fluidsynth volume gain too high #7253

Merged
merged 1 commit into from Feb 21, 2019

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented Feb 19, 2019

No description provided.

@nielsmh
Copy link
Contributor

nielsmh commented Feb 20, 2019

I'm impressed the gain range for fluidsynth is 0.0 to 10.0, default is 0.2, and anything above that easily causes clipping.

Would it be too much to ask to make it a configurable setting for the music driver, similar to how the Win32 and DMusic drivers allows selecting a MIDI port? Users would only be able to configure it via commandline or editing the ini file, but still an option for advanced users who may be using a different sound font with different volume characteristics.

@michicc michicc requested a review from nielsmh February 20, 2019 23:11
Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything straight up wrong with this. If anyone complains about too low volume we can implement a configuration for max gain at that time.

@nielsmh nielsmh merged commit 8a6e03c into OpenTTD:master Feb 21, 2019
@nielsmh
Copy link
Contributor

nielsmh commented Mar 30, 2019

Let me be the one to complain about low volume. The music is way too soft compared to sound effects at this level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants