Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radarr module: add more options and refactor #56061

Merged
merged 1 commit into from Feb 20, 2019
Merged

radarr module: add more options and refactor #56061

merged 1 commit into from Feb 20, 2019

Conversation

elseym
Copy link
Member

@elseym elseym commented Feb 19, 2019 •
edited

Motivation for this change

makes user, group, config location, and opening the firewall port for the webui configurable (similar to modules like sonarr or nzbget) in a backward-compatible manner.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Feb 20, 2019

@GrahamcOfBorg test radarr

@etu etu merged commit 66404f0 into NixOS:master Feb 20, 2019
@elseym elseym deleted the radarr-module branch February 20, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elseym @etu @GrahamcOfBorg