prometheus: add tls_config #56017
Merged
prometheus: add tls_config #56017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval |
10 tasks
basvandijk
suggested changes
Apr 9, 2019
| promTypes.tls_config = types.submodule { | ||
| options = { | ||
| ca_file = mkOption { | ||
| type = types.nullOr types.path; |
There was a problem hiding this comment.
Please change the type to types.nullOr types.str.
Using a path like:
{
tls_config = {
ca_file = ./my-secret-ca-file;
};
}causes ./my-secret-ca-file to end up in the world-readable Nix store. We shouldn't force users to store their secrets there.
When using a string users can specify a path which is relative to the target system like "/run/keys/my-secret-ca-file" for example. This then won't cause that file to be copied to the Nix store.
If users do want to store their secret in the Nix store they can always use:
{
tls_config = {
ca_file = "${./my-secret-ca-file}";
};
}
|
Hi @basvandijk, thanks for your feedback and that thoughtful change request. I've changed the path's to |
basvandijk
approved these changes
Apr 12, 2019
|
@GrahamcOfBorg test prometheus prometheus2 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
added this config part for tls_auth:
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#tls_config
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)