Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

murmur_git: Fix #56096

Merged
merged 1 commit into from Mar 4, 2019
Merged

murmur_git: Fix #56096

merged 1 commit into from Mar 4, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Feb 20, 2019 •
edited

Was failing with the following error when running a service with it:

ServerDB: Database driver QSQLITE not available

This fix is only needed for the git version of murmur.

Ping @jgeerds

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): +0.0002%
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
murmur_git: Fix
3b2168e 
Was failing with the following error:

  ServerDB: Database driver QSQLITE not available
@infinisil
Copy link
Member Author

Ping @wkennington

@infinisil
Copy link
Member Author

I have verified that this fixes the issue with my own murmur NixOS module here (might upstream later)

@infinisil infinisil merged commit e56d2be into NixOS:master Mar 4, 2019
@infinisil infinisil mentioned this pull request Mar 10, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgeerds jgeerds Awaiting requested review from jgeerds

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @GrahamcOfBorg