Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: make z3 dependency optional #56095

Merged
merged 1 commit into from Feb 20, 2019
Merged

solc: make z3 dependency optional #56095

merged 1 commit into from Feb 20, 2019

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Feb 20, 2019 •
edited

Motivation for this change

It is an optional dependency, which defaults to true.

https://solidity.readthedocs.io/en/latest/installing-solidity.html#smt-solvers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric asymmetric changed the title solc: make z4 dependency optional solc: make z3 dependency optional Feb 20, 2019
@srhb
Copy link
Contributor

srhb commented Feb 20, 2019

Verified that the hash is unchanged in the default case.

@srhb srhb merged commit 51005ba into NixOS:master Feb 20, 2019
@asymmetric asymmetric deleted the solc-z4-opt branch February 20, 2019 17:52
@asymmetric asymmetric mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asymmetric @srhb @GrahamcOfBorg