Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xavs: build on darwin #56070

Merged
merged 1 commit into from Feb 24, 2019
Merged

xavs: build on darwin #56070

merged 1 commit into from Feb 24, 2019

Conversation

jacereda
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build xavs

LnL7
LnL7 approved these changes Feb 20, 2019
View reviewed changes
pkgs/development/libraries/xavs/default.nix Outdated
'' + stdenv.lib.optionalString stdenv.isDarwin ''
substituteInPlace config.guess --replace 'uname -p' 'uname -m'
substituteInPlace configure --replace '-O4' '-O3'
substituteInPlace configure --replace ' -s ' ' '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

substituteInPlace can take multiple replace flags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@LnL7
Copy link
Member

LnL7 commented Feb 20, 2019

@GrahamcOfBorg build xavs

@xeji xeji merged commit 36e0ed2 into NixOS:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jacereda @matthewbauer @LnL7 @GrahamcOfBorg @xeji