Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmwareLinuxNonfree: 2018-12-13 -> 2019-02-13 #56068

Merged
merged 1 commit into from Feb 20, 2019
Merged

firmwareLinuxNonfree: 2018-12-13 -> 2019-02-13 #56068

merged 1 commit into from Feb 20, 2019

Conversation

andir
Copy link
Member

@andir andir commented Feb 19, 2019

Motivation for this change

In an attempt to fix a weird WiFi bug I bumped the package locally and there is no good reason not to submit it :-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fpletz
fpletz approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense right before the 19.03 feature freeze. 👍

@flokli flokli merged commit aaa0228 into NixOS:master Feb 20, 2019
@andir andir deleted the linux-firmware-nonfree branch February 20, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @fpletz @flokli @GrahamcOfBorg