Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alpha-embedded: isAlpha code Added #56090

Merged
merged 4 commits into from Feb 20, 2019
Merged

alpha-embedded: isAlpha code Added #56090

merged 4 commits into from Feb 20, 2019

Conversation

vincrusher
Copy link
Contributor

Motivation for this change

Hydra still can't build the alpha-embedded tools as there is another error. This time, the isAlpha code was missing. This is the fix for the missing code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member

dasJ commented Feb 20, 2019

Could you squash these commits?

@matthewbauer matthewbauer merged commit 1eca836 into NixOS:master Feb 20, 2019
@matthewbauer
Copy link
Member

I can squash it before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vincrusher @dasJ @matthewbauer @GrahamcOfBorg