-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.coc: init at 19.02.2019 #56091
Conversation
This package will need a few extra steps in order to function: https://github.com/neoclide/coc.nvim/wiki/Install-coc.nvim. There are several examples how to achieve that in |
@tobim Is it possible to specify the dependency of watchman as an option? It would allow people to override it when installing the vim package (but I have experience with options / configurations). Should that even be done? I can make the package batteries included. |
I'm inclined to say "batteries included" is the way to go for this kind of plugin. |
@tobim the build requires the pulling of some NPM packages, which it cannot do, because it's sandboxed (I'm on NixOS). I generated the npm dependencies for the project with |
Not my area of expertise, but a |
@tobim Thanks, that was useful, I've updated the override and the build. Now the packages are local and I've also included watchman to the mix. I don't know how to test the changes from the nixpkgs fork though, can you give it a shot? |
I tried an ran into a few problems. I added the generated derivation to the node2nix -8 package.json --composition node.nix --node-env ./../../../../development/node-packages/node-env.nix Building that fails however, because it tries to access a file that is in the source of coc:
I think the approach needs to be changed to something similar to what LanguageClient-neovim does on |
@tobim I tried to get yarn to find the offline modules, but that fails. The |
would be neat to have to test the neovim floating window system (as advertised on coc homepage): |
Sorry for the silence from my side. I don't really have the time to do this right now, at least not in the next couple of weeks. |
I thought it would be a nightmare to install but in fact reasonably little is required to get started (non declarative way). I've pushed the most basic plugin possible at #61796 |
It's not as good as nix integration but seems like setting |
This pull request has been mentioned on Nix community. There might be relevant details there: |
I'm back working on this, if anyone has any ideas how to integrate it, please share. |
I'll close this for now and re-openen it when it's ready. |
@ivegotasthma do you have by any chance coc-python working ? you seem to be one with the best coc understanding out there :) |
@teto I don't :/ I'm a newb when it comes to nix expressions and this task seems too complex for my skill set. Anyone is welcome to take it over. |
Sorry, I am a little bit confused, please help me clarify some question. Do this have any relation with (supposedly working for anyone but me) But I can't make it to work correctly in nix-shell (details here and here) Also there are couples of If I use one of those, do I still need to use |
Regarding plugins it seems that some of them work and some don't(https://github.com/rvolosatovs/infrastructure/blob/8b68427ff259299b94838aa89a2d1036f6d1e099/nixpkgs/neovim/default.nix#L10-L15), but I honestly don't use them, as |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)