cudatoolkit: Several fixes #56018
Merged
cudatoolkit: Several fixes #56018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ncurses upgrade to libncurses.so.6 did silently break cuda-gdb quite some time ago.
knedlsepp
force-pushed
the
fix-cuda-gdb
branch
from
6a46225
to
4bf81bb
Compare
knedlsepp
changed the title
knedlsepp
changed the title
|
Hm. It seems the issues with the GUI applications |
Versions prior to 9.0 did not build. Additionally we add some smoke tests for the binaries in $out/bin.
This fixes the following error when starting nvvp or nsight: ``` (java:23876): Gtk-WARNING **: 19:12:17.777: Unable to locate theme engine in module_path: "adwaita", A fatal error has been detected by the Java Runtime Environment: SIGSEGV (0xb) at pc=0x00007f957f7b67fe, pid=23876, tid=140281059333888 JRE version: Java(TM) SE Runtime Environment (8.0_77-b03) (build 1.8.0_77-b03) Java VM: Java HotSpot(TM) 64-Bit Server VM (25.77-b03 mixed mode linux-amd64 compressed oops) Problematic frame: C [libpixbufloader-bmp.so+0x27fe] gdk_pixbuf__bmp_image_load_increment+0xeee ``` Since GDK_PIXBUF_MODULE_FILE should match the version we actually link to, we override the environment variable using the one provided by the gdk_pixbuf setup-hook.
knedlsepp
force-pushed
the
fix-cuda-gdb
branch
from
8b4a975
to
3e0723f
Compare
|
@Mic92 Would you mind having a look at these fixes? |
|
confirmed failure, fix and lgtm |
bendlas
added a commit
that referenced
this pull request
Mar 10, 2019
cudatoolkit: Several fixes (cherry picked from commit b854767)
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The ncurses upgrade to libncurses.so.6 did silently break cuda-gdb quite some time ago. To reduce the chance of it breaking again we introduce simple smoke tests that do run all the programs shipped with
cudatoolkit. We add some fixes for the GUI applications, upgrade cudatoolkit-9.0 and make sure all older versions build.
#56826 Please backport to 19.03
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)