lenovo-x1: removed battery TLP threshholds #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eyJhb can you convert removed part to module instead? |
|
Modules have been out of scope for this project (so far). |
lukateras
approved these changes
Feb 19, 2019
|
You could have at least left it commented |
|
I see no reason for letting it stay as a comment :) Anyways, case closed. If anyone see fit adding something like this as a module, feel free! :) |
|
It is useful yes, but there still is the normal possibility for adding it to the configuration.nix? But yeah, options would be nice. :) https://github.com/eyJhb/dot/blob/master/dotfiles/nixos/configuration.nix#L292-L301 |
danbst
added a commit
to danbst/nixos-hardware
that referenced
this pull request
Feb 19, 2019
- convert `common/cpu/intel` and `common/pc/laptop/acpi_call` to proper modules. This allows a) descriptions and b) enable/disable instead of `import` - enable both for thinkpad by default. Disable explicitly in specific profiles (for example, AMD ThinkPads don't need those). This is mostly to remove repetitions and make a "generic" ThinkPad config (I have E470 but none of profiles matches my needs). - add `hardware.cpu.intel.max-frequency` option, which allows reducing CPU performance (a bit duplicates powerManagement.cpufreq.max but it's a separate mechanism). Perhaps should eventually move to nixpkgs? - add `hardware.battery.powersave`, which enables some non-controversial power saving services. Disabled by default. - add `hardware.battery.optimize`, which documents nuances of battery lifetime. Basically, ressurects deleted in NixOS#100 code but disabled by default. - convert a comment about fprintd into an option `hardware.fingerprint.enable`, with description What you think about this? I'm now using those options as: ``` imports = [ <nixos-hardware/lenovo/thinkpad> ]; hardware.battery.powersave = true; hardware.battery.optimize = "mostly-pluggedin"; hardware.fingerprint.enable = true; # increase nixos-rebuild time from 4.3s to 4.7s hardware.cpu.intel.max-frequency = 90; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98 , as it should not be set.