Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: Bump CoreDNS and Dashboard #56001

Merged
merged 2 commits into from Feb 19, 2019
Merged

nixos/kubernetes: Bump CoreDNS and Dashboard #56001

merged 2 commits into from Feb 19, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 18, 2019

Motivation for this change

Versions of both of the bundled Kubernetes addons are getting old. We should bump those to the latest versions before 19.03 branch-off.
i.e.

  • coredns 1.2.5 -> 1.3.1
  • dashboard 1.8.3 -> 1.10.1

Although kubernetes-dashboard maintainers officially state that the latest version of the dashboard doesn't support k8s v1.13 (https://github.com/kubernetes/dashboard/releases/tag/v1.10.1); both components have been tested on Kubernets v1.11.6 and v1.13.3 and they work fine. In any case, the newest version of the dashboard must be best at supporting the newest version of k8s.

The dashboard release note also states that a new flag has been added. In order for users to be able to take advantage of this flag (and others), I've added a new option to the dashboard module, extraArgs with which additional cmdline args to the dashboard can be appended.

@GrahamcOfBorg test kubernetes.dns.singlenode kubernetes.dns.multinode

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Johan Thomsen added 2 commits February 18, 2019 17:34
nixos/kubernetes: coredns 1.2.5 -> 1.3.1
5af74e1
nixos/kubernetes: dashboard 1.8.3 -> 1.10.1
f738618 
- add option to specify extra cmdline arguments to the dashboard
@johanot
Copy link
Contributor Author

johanot commented Feb 18, 2019

@GrahamcOfBorg eval

@johanot johanot force-pushed the coredns-1.3.1-dashboard-1.10.1 branch from ff3a619 to f738618 Compare February 18, 2019 19:05
@johanot
Copy link
Contributor Author

johanot commented Feb 18, 2019

@GrahamcOfBorg eval

@johanot
Copy link
Contributor Author

johanot commented Feb 18, 2019

third time's the charm
@GrahamcOfBorg eval

@johanot
Copy link
Contributor Author

johanot commented Feb 18, 2019

@GrahamcOfBorg test kubernetes.dns.singlenode kubernetes.dns.multinode

@srhb
Copy link
Contributor

srhb commented Feb 19, 2019

Can you elaborate a bit on your considerations regarding the dashboard compatibility chart? The fact that it has an explicit X and not just a question mark worries me, this seems like they know there are things that do not work, doesn't it?

@srhb
Copy link
Contributor

srhb commented Feb 19, 2019

Looks like the issue at hand is the heapster v. metrics change.

@johanot
Copy link
Contributor Author

johanot commented Feb 19, 2019

I agree with your concerns, but on the other hand I feel that dashboard v1.10.1 by definition has to support k8s 1.13 better than v1.8.3 does (which also has the x next to 1.13 by the way). I somehow feel that the x is there only to indicate that they can't guarantee everything works. I already tested basic features on the dashboard with the 1.10, 1.13 combination, and it seems to work just fine.

IMHO, either we ship the dashboard as is, while keeping it as updated as possible, or we abandon support for the dashboard alltogether, with reference to the compatibility mismatch. I prefer the former. What do you say? :)

@srhb
Copy link
Contributor

srhb commented Feb 19, 2019

You're right, I completely overlooked the v1.8.3 issue, thanks

@srhb srhb merged commit 45fceae into NixOS:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @srhb @GrahamcOfBorg