Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Introduce database pool size option #56072

Merged
merged 1 commit into from Feb 20, 2019
Merged

nixos/gitlab: Introduce database pool size option #56072

merged 1 commit into from Feb 20, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Feb 19, 2019

Motivation for this change

It turns out it is sometimes necessary to adjust this. As well as a extraDatabaseConfig option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz fpletz requested review from globin and flokli February 19, 2019 22:34
@bgamari
nixos/gitlab: Introduce database pool size option
bd5ba09 
As well as a extraDatabaseConfig option.
@flokli flokli merged commit 11699d0 into NixOS:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@flokli flokli flokli approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @fpletz @flokli @GrahamcOfBorg