Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPF ships locked in a reverse-loop #7244

Closed
SamuXarick opened this issue Feb 18, 2019 · 7 comments
Closed

OPF ships locked in a reverse-loop #7244

SamuXarick opened this issue Feb 18, 2019 · 7 comments

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

master-g45ce517105

Expected result

opf ships should know they can't do a 90 degrees turn after a reverse

Actual result

opf ships get stuck in a reverse-loop, doing 180 degree turns against an obstacle, reverse, advance a tile, and do 180 degree turn again, heading back against the shore again.

Steps to reproduce

Load savegame, ships 78, 59, 77, 75, 79, 81, 80.
Koln Mines Shipping, 1996-12-30.zip

@SamuXarick
Copy link
Contributor Author

Offending commit: 6ca637b

@J0anJosep
Copy link
Contributor

Ok. I will fix this one. It is an easy one. Tomorrow you'll have your fix.

@SamuXarick
Copy link
Contributor Author

SamuXarick commented Feb 18, 2019

I had forbid 90 deg for opf rejected, which was doing it the right way :/
#7070

@J0anJosep
Copy link
Contributor

But just to let you know...
I've been trying to develop new features for water transport. OPF just tries to "guess" a path and fails too many times.
I would like to see it removed. It is not good at pathfinding, not only because of 90 deg turns. It is obsolete and in my opinion any second trying to improve it is a wasted second.

The other thing is why 90 deg setting isn't separated into two settings, one for ships and another for trains.

@PeterN
Copy link
Member

PeterN commented Feb 18, 2019

Regarding the last thing, when I was going to do that originally all feedback said just remove it for ships.

@glx22
Copy link
Contributor

glx22 commented Feb 18, 2019

Indeed "forbid 90°" only matters for trains. Ships can turn on spot.

@J0anJosep
Copy link
Contributor

I am trying to develop water features and one of them is making ships avoiding rotation (I like the rotation feature, but I also try to make water routes more interesting for gameplay purposes). That is why I ask to keep this setting for ships.
If there is no intention on improving water transport (as making ships crossing over each other), it can be removed from master.

J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 18, 2019
@LordAro LordAro mentioned this issue Feb 18, 2019
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants